Skip to content

Code of conduct#2174

Merged
stevenengler merged 3 commits intoshadow:mainfrom
stevenengler:code-of-conduct
Feb 6, 2023
Merged

Code of conduct#2174
stevenengler merged 3 commits intoshadow:mainfrom
stevenengler:code-of-conduct

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

@stevenengler stevenengler commented May 19, 2022 •
edited
Loading

This uses the "Contributor Covenant" template, with the following changes:

  1. Shortened the 'Enforcement Guidelines' section of code of conduct. — As a small project with few people, I think it would be better to handle code of conduct violations on a case-by-case basis rather than codifying our enforcement guidelines.
  2. Added to the 'Scope' section of code of conduct. — I think this paragraph from Tor's code of conduct is good to have.
  3. Added a contact email address.

Closes #2146. Feedback welcome.

@stevenengler stevenengler added the Component: Documentation In-repository documentation, under docs/ label May 19, 2022
@stevenengler stevenengler self-assigned this May 19, 2022
robgjansen
robgjansen approved these changes Jan 31, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@robgjansen robgjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@stevenengler stevenengler marked this pull request as ready for review January 31, 2023 22:45
sporksmith
sporksmith approved these changes Feb 1, 2023
View reviewed changes
@stevenengler stevenengler force-pushed the code-of-conduct branch 2 times, most recently from d97c351 to e91f76e Compare February 1, 2023 16:52
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 1, 2023 •
edited
Loading

Codecov Report

Base: 67.03% // Head: 67.53% // Increases project coverage by +0.50% 🎉

Coverage data is based on head (d97c351) compared to base (6064cc8).
Patch has no changes to coverable lines.

❗ Current head d97c351 differs from pull request most recent head 7050c95. Consider uploading reports for the commit 7050c95 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2174      +/-   ##
==========================================
+ Coverage   67.03%   67.53%   +0.50%     
==========================================
  Files         203      203              
  Lines       30513    30484      -29     
  Branches     5970     5961       -9     
==========================================
+ Hits        20454    20588     +134     
+ Misses       5375     5228     -147     
+ Partials     4684     4668      -16
Flag Coverage Δ
tests 67.53% <ø> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/host/descriptor/socket/inet/mod.rs 28.12% <0.00%> (-15.19%) ⬇️
src/main/host/descriptor/socket/inet/tcp.rs 67.02% <0.00%> (-3.25%) ⬇️
src/lib/shmem/src/scmutex.rs 87.05% <0.00%> (-2.36%) ⬇️
src/main/host/network_interface.rs 91.37% <0.00%> (-0.43%) ⬇️
src/main/network/net_namespace.rs 77.98% <0.00%> (-0.40%) ⬇️
src/main/utility/byte_queue.rs 56.01% <0.00%> (ø)
src/main/core/manager.rs 63.41% <0.00%> (+0.22%) ⬆️
src/main/host/descriptor/mod.rs 67.47% <0.00%> (+0.40%) ⬆️
src/main/host/syscall/handler/socket.rs 66.66% <0.00%> (+0.44%) ⬆️
src/main/core/support/units.rs 56.36% <0.00%> (+0.51%) ⬆️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stevenengler stevenengler merged commit ed9d8c4 into shadow:main Feb 6, 2023
@stevenengler stevenengler deleted the code-of-conduct branch February 6, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sporksmith sporksmith sporksmith approved these changes

@robgjansen robgjansen robgjansen approved these changes

Assignees

@stevenengler stevenengler

Labels

Component: Documentation In-repository documentation, under docs/

Projects

None yet

Milestone

Code health and maintenance

Development

Successfully merging this pull request may close these issues.

Add code of conduct

3 participants

@stevenengler @sporksmith @robgjansen