Distinguish between sources of death by SIGKILL#2171
Merged
sporksmith merged 3 commits intoshadow:mainfrom May 20, 2022
Merged
Conversation
stevenengler
approved these changes
May 20, 2022
Contributor
stevenengler
left a comment
There was a problem hiding this comment.
Oops, meant to approve.
Regression test for shadow#2151
* Treat death by signal 9 as an error if Shadow didn't intentionally use it to stop the process. * Write an empty exitcode file when Shadow does kill the process (via signal 9), which is a more intuitive result for a process that didn't exit within the simulation itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a regression test for Shadow will return success even when plugins are killed by Linux OOM killer #2151
Treat death by signal 9 as an error if Shadow didn't
intentionally use it to stop the process.
Write an empty exitcode file when Shadow does kill the process (via
signal 9), which is a more intuitive result for a process that didn't
exit within the simulation itself.
Fixes #2151