Skip to content

Enable syscall counters by default#2019

Merged
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:enable-syscall-counters
Apr 11, 2022
Merged

Enable syscall counters by default#2019
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:enable-syscall-counters

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

@stevenengler stevenengler commented Apr 11, 2022 •
edited
Loading

There doesn't seem to be any performance penalty on a 5% network: https://github.com/shadow/benchmark-results/tree/master/tor/2022-04-11-T14-10-42

@stevenengler stevenengler added the Type: Enhancement New functionality or improved design label Apr 11, 2022
@stevenengler stevenengler self-assigned this Apr 11, 2022
@github-actions github-actions bot added the Component: Main Composing the core Shadow executable label Apr 11, 2022
@stevenengler stevenengler requested a review from sporksmith April 11, 2022 21:35
@stevenengler stevenengler force-pushed the enable-syscall-counters branch from a777d5f to 76565e3 Compare April 11, 2022 21:47
@stevenengler stevenengler enabled auto-merge April 11, 2022 21:47
@stevenengler stevenengler merged commit 4b8d639 into shadow:main Apr 11, 2022
@stevenengler stevenengler deleted the enable-syscall-counters branch April 11, 2022 22:28
@stevenengler stevenengler mentioned this pull request Jun 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sporksmith sporksmith sporksmith approved these changes

Assignees

@stevenengler stevenengler

Labels

Component: Main Composing the core Shadow executable Type: Enhancement New functionality or improved design

Projects

None yet

Milestone

Code health and maintenance

Development

Successfully merging this pull request may close these issues.

2 participants

@stevenengler @sporksmith