Explicitly initialize shim's new thread state after clone#1943
Merged
sporksmith merged 2 commits intoshadow:mainfrom Mar 2, 2022
Merged
Explicitly initialize shim's new thread state after clone#1943sporksmith merged 2 commits intoshadow:mainfrom
sporksmith merged 2 commits intoshadow:mainfrom
Conversation
de6c732 to
b142440
Compare
d9eef44 to
ab38c58
Compare
4 tasks
ab38c58 to
78be3a0
Compare
Contributor
Author
|
Demo of the underlying issue this solves: godbolt |
Contributor
Author
|
Relevant message to LKML for posterity: https://lkml.org/lkml/2022/3/2/602 |
stevenengler
approved these changes
Mar 2, 2022
Contributor
stevenengler
left a comment
There was a problem hiding this comment.
This seems like it was fun to debug :)
Fixes shadow#1931 Also reduces the failure rate of the goroutines test (shadow#1932) from ~80% to ~10%.
78be3a0 to
2d9de12
Compare
Contributor
Author
Hah, yes and no. Definitely got more fun as I homed in on the root cause, but spent some painful time getting there from "memory corruption happened at some earlier point" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1931 and #1549.
Also reduces the failure rate of the goroutines test
(#1932) from ~80% to ~10%.