Improve behaviour when TCP_NODELAY is set#1936
Merged
stevenengler merged 1 commit intoshadow:mainfrom Mar 1, 2022
Merged
Conversation
robgjansen
approved these changes
Feb 25, 2022
2278cf6 to
0b8e171
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shadow doesn't support nagle's algorithm, so shadow always behaves as if
TCP_NODELAYis enabled. Some programs will fail ifsetsockopt(fd, SOL_TCP, TCP_NODELAY, &1, sizeof(int))returns an error, so we treat this as a no-op for compatibility.Three examples I can think of that fail when they're unable to set
TCP_NODELAYare nginx (unless usingtcp_nodelay off), python's urllib library, and salticidae-based programs.