Add select syscall handler and tests#1910
Merged
robgjansen merged 4 commits intoshadow:mainfrom Feb 18, 2022
Merged
Conversation
5b97244 to
d730625
Compare
stevenengler
approved these changes
Feb 17, 2022
Contributor
stevenengler
left a comment
There was a problem hiding this comment.
Looks good to me! Now python's sleep() will work :)
The new tests are closely modeled after our existing poll tests.
d730625 to
3183bdc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides support for the
select()system call:I decided to implement the handler in C first - it internally uses some code from our poll handler whose functionality is largely similar. I'll loop around to convert both the poll and select handlers to rust.
Closes #1721