Skip to content

Add unnamed unix sockets created with socketpair()#1787

Merged
stevenengler merged 5 commits intoshadow:mainfrom
stevenengler:unix-sockets
Nov 29, 2021
Merged

Add unnamed unix sockets created with socketpair()#1787
stevenengler merged 5 commits intoshadow:mainfrom
stevenengler:unix-sockets

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

@stevenengler stevenengler commented Nov 24, 2021

This replaces the existing C version, which was limited to only stream sockets.

@stevenengler
Minor change to 'Trigger::from_posix_file()'
199437e
@stevenengler
SharedBuf returns EMSGSIZE if the message is larger than the buffer size
6a85374 
This is useful for dgram unix sockets which don't have max message sizes like
pipes (PIPE_BUF) and udp (65,527).
@stevenengler stevenengler added the Type: Enhancement New functionality or improved design label Nov 24, 2021
@stevenengler stevenengler self-assigned this Nov 24, 2021
@github-actions github-actions bot added Component: Build Build/install tools and dependencies Component: Main Composing the core Shadow executable Component: Testing Unit and integration tests and frameworks labels Nov 24, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 24, 2021 •
edited
Loading

Codecov Report

Merging #1787 (151d67a) into main (273f12e) will decrease coverage by 0.61%.
The diff coverage is 63.09%.

❗ Current head 151d67a differs from pull request most recent head b725269. Consider uploading reports for the commit b725269 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1787      +/-   ##
==========================================
- Coverage   62.24%   61.62%   -0.62%     
==========================================
  Files         224      226       +2     
  Lines       33882    34607     +725     
  Branches     7188     7282      +94     
==========================================
+ Hits        21089    21327     +238     
- Misses       7889     8309     +420     
- Partials     4904     4971      +67
Flag Coverage Δ
tests 61.62% <63.09%> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/bindings/rust/wrapper.rs 41.63% <ø> (ø)
src/main/host/descriptor/transport.c 66.66% <ø> (-2.57%) ⬇️
src/main/host/host.c 72.61% <ø> (ø)
src/main/host/process.c 72.16% <ø> (ø)
src/main/host/syscall/uio.c 22.42% <ø> (+0.78%) ⬆️
src/main/host/syscall/unistd.c 59.09% <ø> (+4.92%) ⬆️
src/main/host/syscall_types.rs 76.47% <0.00%> (+0.42%) ⬆️
src/main/host/syscall/unistd.rs 67.74% <5.26%> (-4.99%) ⬇️
src/main/host/descriptor/mod.rs 66.02% <22.22%> (-1.12%) ⬇️
src/main/host/descriptor/socket/mod.rs 4.56% <25.92%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 273f12e...b725269. Read the comment docs.

sporksmith
sporksmith requested changes Nov 24, 2021
View reviewed changes
sporksmith
sporksmith requested changes Nov 29, 2021
View reviewed changes
@stevenengler stevenengler merged commit a663351 into shadow:main Nov 29, 2021
@stevenengler stevenengler deleted the unix-sockets branch November 29, 2021 22:58
@stevenengler stevenengler mentioned this pull request Nov 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sporksmith sporksmith sporksmith approved these changes

Assignees

@stevenengler stevenengler

Labels

Component: Build Build/install tools and dependencies Component: Main Composing the core Shadow executable Component: Testing Unit and integration tests and frameworks Type: Enhancement New functionality or improved design

Projects

None yet

Milestone

Implement UNIX socket descriptors in ...

Development

Successfully merging this pull request may close these issues.

2 participants

@stevenengler @sporksmith