Skip to content

Add support for the 'O_DIRECT' flag to pipes (packet mode)#1746

Merged
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:pipe-o-direct
Oct 28, 2021
Merged

Add support for the 'O_DIRECT' flag to pipes (packet mode)#1746
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:pipe-o-direct

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

@stevenengler stevenengler commented Oct 21, 2021

Closes #1720.

@stevenengler stevenengler added Component: Testing Unit and integration tests and frameworks Component: Main Composing the core Shadow executable labels Oct 21, 2021
@stevenengler stevenengler self-assigned this Oct 21, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 21, 2021 •
edited
Loading

Codecov Report

Merging #1746 (19ea36d) into main (f970410) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 19ea36d differs from pull request most recent head 8b79bbd. Consider uploading reports for the commit 8b79bbd to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1746      +/-   ##
==========================================
- Coverage   54.49%   54.48%   -0.02%     
==========================================
  Files         148      148              
  Lines       18969    18969              
  Branches     4556     4556              
==========================================
- Hits        10337    10335       -2     
+ Misses       5882     5880       -2     
- Partials     2750     2754       +4
Flag Coverage Δ
tests 54.48% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/test/futex/test_futex.c 64.21% <0.00%> (-1.06%) ⬇️
src/main/host/descriptor/socket.c 58.21% <0.00%> (-0.36%) ⬇️
src/lib/libc_preload/syscall_wrappers.c 17.77% <0.00%> (-0.31%) ⬇️
src/main/host/syscall/socket.c 78.63% <0.00%> (-0.15%) ⬇️
src/lib/tsc/tsc_test.c 30.37% <0.00%> (ø)
src/lib/logger/log_level.c 13.63% <0.00%> (ø)
src/main/host/descriptor/file.c 29.89% <0.00%> (+0.18%) ⬆️
src/main/host/syscall/mman.c 65.90% <0.00%> (+0.75%) ⬆️
src/lib/tsc/tsc.c 33.80% <0.00%> (+1.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f970410...8b79bbd. Read the comment docs.

sporksmith
sporksmith approved these changes Oct 26, 2021
View reviewed changes
@stevenengler stevenengler merged commit 39a3dd5 into shadow:main Oct 28, 2021
@stevenengler stevenengler deleted the pipe-o-direct branch October 28, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sporksmith sporksmith sporksmith approved these changes

Assignees

@stevenengler stevenengler

Labels

Component: Main Composing the core Shadow executable Component: Testing Unit and integration tests and frameworks

Projects

None yet

Milestone

Extend support for socket/file options

Development

Successfully merging this pull request may close these issues.

Implement O_DIRECT mode for pipes

2 participants

@stevenengler @sporksmith