Set default min runahead to 1ms#1711
Merged
robgjansen merged 1 commit intoshadow:mainfrom Oct 11, 2021
Merged
Conversation
Member
Author
|
Effect on Shadow performance in a 10% Tor network when adjusting We might also consider increasing to larger than 1ms - I do not notice Tor performance changes that could be attributed to changing the runahead to 1ms or 2ms. |
Codecov Report
@@ Coverage Diff @@
## main #1711 +/- ##
=======================================
Coverage 54.46% 54.47%
=======================================
Files 144 144
Lines 18940 18940
Branches 4551 4551
=======================================
+ Hits 10316 10317 +1
- Misses 5869 5870 +1
+ Partials 2755 2753 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
stevenengler
approved these changes
Oct 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Larger values for the
--runaheadoption improves our ability to parallelize work across workers, leading to faster run-times. 1 millisecond was the lowest possible minimum in Shadow 1.x, and I think a reasonable default since most latencies for our target networks are in terms of milliseconds.refs #1699