Skip to content

Move host heartbeat options to the experimental options, and disable by default#1703

Merged
stevenengler merged 4 commits intoshadow:mainfrom
stevenengler:move-heartbeat-options
Oct 6, 2021
Merged

Move host heartbeat options to the experimental options, and disable by default#1703
stevenengler merged 4 commits intoshadow:mainfrom
stevenengler:move-heartbeat-options

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

Closes #1672.

@stevenengler stevenengler added the Type: Enhancement New functionality or improved design label Oct 6, 2021
@stevenengler stevenengler self-assigned this Oct 6, 2021
@github-actions github-actions bot added Component: Documentation In-repository documentation, under docs/ Component: Main Composing the core Shadow executable labels Oct 6, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 6, 2021

Codecov Report

Merging #1703 (5f2d5ad) into main (55b0bbb) will decrease coverage by 0.86%.
The diff coverage is 12.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1703      +/-   ##
==========================================
- Coverage   55.45%   54.59%   -0.87%     
==========================================
  Files         145      145              
  Lines       18879    18903      +24     
  Branches     4523     4537      +14     
==========================================
- Hits        10470    10320     -150     
- Misses       5641     5829     +188     
+ Partials     2768     2754      -14     
Flag Coverage Δ
tests 54.59% <12.24%> (-0.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/core/work/event.c 62.16% <0.00%> (-1.73%) ⬇️
src/main/host/descriptor/socket.c 58.21% <0.00%> (-7.46%) ⬇️
src/main/host/descriptor/tcp.c 76.92% <0.00%> (-0.50%) ⬇️
src/main/host/host.c 71.47% <0.00%> (-1.23%) ⬇️
src/main/host/process.c 68.95% <ø> (ø)
src/main/host/network_interface.c 71.63% <33.33%> (-1.71%) ⬇️
src/main/core/manager.c 66.43% <50.00%> (-0.16%) ⬇️
src/main/core/controller.c 70.42% <100.00%> (ø)
src/main/host/tracker.h 0.00% <0.00%> (-100.00%) ⬇️
src/main/host/tracker.c 0.00% <0.00%> (-38.65%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55b0bbb...5f2d5ad. Read the comment docs.

@stevenengler stevenengler merged commit 98c7aae into shadow:main Oct 6, 2021
@stevenengler stevenengler deleted the move-heartbeat-options branch October 6, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Documentation In-repository documentation, under docs/ Component: Main Composing the core Shadow executable Type: Enhancement New functionality or improved design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move host heartbeat options to experimental options and disable by default

2 participants