poll and epoll: wait for timeout even with no fd's#1697
Merged
sporksmith merged 1 commit intoshadow:mainfrom Oct 1, 2021
Merged
poll and epoll: wait for timeout even with no fd's#1697sporksmith merged 1 commit intoshadow:mainfrom
sporksmith merged 1 commit intoshadow:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1697 +/- ##
=======================================
Coverage 56.25% 56.25%
=======================================
Files 140 140
Lines 18567 18564 -3
Branches 4477 4476 -1
=======================================
- Hits 10444 10443 -1
+ Misses 5403 5402 -1
+ Partials 2720 2719 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
stevenengler
approved these changes
Oct 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular, curl uses
pollwith nfds=0 but a non-zero timeout to wait in what would otherwise be a busy-loop that doesn't advance time.Progress on #1549