Skip to content

Use self-loops for paths from a graph node to itself#1681

Merged
stevenengler merged 3 commits intoshadow:mainfrom
stevenengler:require-self-loops
Sep 27, 2021
Merged

Use self-loops for paths from a graph node to itself#1681
stevenengler merged 3 commits intoshadow:mainfrom
stevenengler:require-self-loops

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

Closes #1679.

@stevenengler stevenengler added the Type: Enhancement New functionality or improved design label Sep 27, 2021
@stevenengler stevenengler self-assigned this Sep 27, 2021
@github-actions github-actions bot added Component: Documentation In-repository documentation, under docs/ Component: Main Composing the core Shadow executable labels Sep 27, 2021
Always use self-loops when calculating the path from a node to
itself. This replaces the previous behaviour where we would find
the shortest path that includes at least one edge.
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 27, 2021

Codecov Report

Merging #1681 (8d463f4) into main (5456859) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1681      +/-   ##
==========================================
- Coverage   56.27%   56.25%   -0.02%     
==========================================
  Files         140      140              
  Lines       18555    18555              
  Branches     4474     4474              
==========================================
- Hits        10441    10439       -2     
- Misses       5398     5399       +1     
- Partials     2716     2717       +1     
Flag Coverage Δ
tests 56.25% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/core/worker.c 75.49% <0.00%> (-0.67%) ⬇️
src/main/host/descriptor/descriptor.c 73.33% <0.00%> (-0.61%) ⬇️
src/main/host/network_interface.c 73.04% <0.00%> (ø)
src/main/host/tracker.c 38.98% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5456859...8d463f4. Read the comment docs.

@stevenengler stevenengler merged commit 71e7748 into shadow:main Sep 27, 2021
@stevenengler stevenengler deleted the require-self-loops branch September 27, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Documentation In-repository documentation, under docs/ Component: Main Composing the core Shadow executable Type: Enhancement New functionality or improved design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Require self-loops for each graph node, and use them instead of shortest path

2 participants