Remove file from epoll interest list when closed#1660
Merged
stevenengler merged 1 commit intoshadow:mainfrom Sep 22, 2021
Merged
Remove file from epoll interest list when closed#1660stevenengler merged 1 commit intoshadow:mainfrom
stevenengler merged 1 commit intoshadow:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1660 +/- ##
==========================================
- Coverage 56.33% 56.27% -0.07%
==========================================
Files 140 140
Lines 18547 18550 +3
Branches 4471 4473 +2
==========================================
- Hits 10449 10439 -10
- Misses 5385 5392 +7
- Partials 2713 2719 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
robgjansen
approved these changes
Sep 22, 2021
2f0fcf4 to
761ee7e
Compare
stevenengler
commented
Sep 22, 2021
Contributor
Author
stevenengler
left a comment
There was a problem hiding this comment.
I noticed a bug after reviewing, so I fixed it as well:
Original:
g_hash_table_remove(epoll->watching, &key);
Fixed:
g_hash_table_remove(epoll->watching, key);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1101.
I don't see a good way to add an integration test for this, but once we have this in rust, a unit test would be easier.