Updated syscall handlers to use rust descriptor lookup#1655
Merged
stevenengler merged 1 commit intoshadow:mainfrom Sep 21, 2021
Merged
Updated syscall handlers to use rust descriptor lookup#1655stevenengler merged 1 commit intoshadow:mainfrom
stevenengler merged 1 commit intoshadow:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1655 +/- ##
==========================================
- Coverage 56.33% 56.32% -0.01%
==========================================
Files 140 140
Lines 18557 18546 -11
Branches 4471 4470 -1
==========================================
- Hits 10454 10446 -8
+ Misses 5389 5383 -6
- Partials 2714 2717 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cc796c7 to
2aacf1d
Compare
sporksmith
approved these changes
Sep 21, 2021
The C close() syscall handler is also now redundant, so it was removed.
2aacf1d to
0eb7b02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C close() syscall handler is also now redundant, so it was removed.
The helper functions also must take a cloned
PosixFile(an enum containing anArc) instead of a&Descriptorsince a&Descriptorholds an immutable reference to theProcessfor the lifetime of the&Descriptor, and cloning thePosixFileallows us to break that reference.