Skip to content

Moved the process descriptor functions to rust#1654

Merged
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:rust-proc-desc-fns
Sep 21, 2021
Merged

Moved the process descriptor functions to rust#1654
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:rust-proc-desc-fns

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

Moved the functions for manipulating a process' descriptor table from C to rust.

@stevenengler stevenengler added the Type: Maintenance Refactoring, cleanup, documenation, or process improvements label Sep 20, 2021
@github-actions github-actions bot added Component: Build Build/install tools and dependencies Component: Main Composing the core Shadow executable labels Sep 20, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 20, 2021

Codecov Report

Merging #1654 (c593c6d) into main (6286262) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1654      +/-   ##
==========================================
- Coverage   56.36%   56.35%   -0.01%     
==========================================
  Files         140      140              
  Lines       18596    18557      -39     
  Branches     4484     4471      -13     
==========================================
- Hits        10481    10458      -23     
+ Misses       5389     5383       -6     
+ Partials     2726     2716      -10     
Flag Coverage Δ
tests 56.35% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/host/process.c 68.82% <100.00%> (+0.90%) ⬆️
src/main/host/syscall/mman.c 65.90% <0.00%> (-1.52%) ⬇️
src/main/core/scheduler/scheduler.c 74.34% <0.00%> (-0.53%) ⬇️
src/main/host/tracker.c 38.64% <0.00%> (-0.34%) ⬇️
src/main/host/descriptor/file.c 29.16% <0.00%> (-0.19%) ⬇️
src/main/host/syscall/socket.c 78.78% <0.00%> (+0.14%) ⬆️
src/main/host/descriptor/socket.c 65.67% <0.00%> (+0.37%) ⬆️
src/main/host/syscall/shadow.c 70.58% <0.00%> (+3.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6286262...c593c6d. Read the comment docs.

@stevenengler stevenengler force-pushed the rust-proc-desc-fns branch 3 times, most recently from 75228fb to 06c10e3 Compare September 20, 2021 22:13
@stevenengler stevenengler marked this pull request as ready for review September 20, 2021 22:13
@stevenengler stevenengler merged commit ccf851c into shadow:main Sep 21, 2021
@stevenengler stevenengler deleted the rust-proc-desc-fns branch September 21, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Build Build/install tools and dependencies Component: Main Composing the core Shadow executable Type: Maintenance Refactoring, cleanup, documenation, or process improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants