Skip to content

Make preload the default interposition mechanism#1649

Merged
sporksmith merged 1 commit intoshadow:mainfrom
sporksmith:preload-default
Sep 17, 2021
Merged

Make preload the default interposition mechanism#1649
sporksmith merged 1 commit intoshadow:mainfrom
sporksmith:preload-default

Conversation

@sporksmith
Copy link
Copy Markdown
Contributor

@sporksmith sporksmith commented Sep 17, 2021

Preload-based interposition is now fairly stable, and is significantly
faster than ptrace. It is now the most sensible default.

Closes #1647

@sporksmith sporksmith enabled auto-merge (squash) September 17, 2021 16:03
@github-actions github-actions bot added Component: Documentation In-repository documentation, under docs/ Component: Main Composing the core Shadow executable labels Sep 17, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 17, 2021 •
edited
Loading

Codecov Report

Merging #1649 (c159dbe) into main (342fd24) will increase coverage by 1.67%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1649      +/-   ##
==========================================
+ Coverage   54.51%   56.18%   +1.67%     
==========================================
  Files         140      140              
  Lines       18561    18561              
  Branches     4471     4471              
==========================================
+ Hits        10118    10428     +310     
+ Misses       5774     5423     -351     
- Partials     2669     2710      +41
Flag Coverage Δ
tests 56.18% <ø> (+1.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/utility/tagged_ptr.c 54.54% <0.00%> (-9.10%) ⬇️
src/lib/logger/log_level.c 13.63% <0.00%> (-4.55%) ⬇️
src/lib/tsc/tsc.c 32.39% <0.00%> (-1.41%) ⬇️
src/main/host/network_interface.c 72.46% <0.00%> (-0.58%) ⬇️
src/main/host/descriptor/file.c 29.29% <0.00%> (-0.19%) ⬇️
src/lib/tsc/tsc_test.c 30.37% <0.00%> (ø)
src/main/host/descriptor/epoll.c 77.45% <0.00%> (ø)
src/main/host/syscall/socket.c 78.78% <0.00%> (+0.14%) ⬆️
src/main/host/process.c 69.25% <0.00%> (+0.37%) ⬆️
src/lib/shim/preload_syscalls.c 45.79% <0.00%> (+0.93%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 342fd24...c159dbe. Read the comment docs.

stevenengler
stevenengler approved these changes Sep 17, 2021
View reviewed changes
@sporksmith sporksmith disabled auto-merge September 17, 2021 16:59
@sporksmith
Make preload the default interposition mechanism
c159dbe 
Preload-based interposition is now fairly stable, and is significantly
faster than ptrace. It is now the most sensible default.

Closes shadow#1647
@sporksmith sporksmith enabled auto-merge (squash) September 17, 2021 17:01
@sporksmith sporksmith merged commit bbf7d01 into shadow:main Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevenengler stevenengler stevenengler approved these changes

Assignees

@sporksmith sporksmith

Labels

Component: Documentation In-repository documentation, under docs/ Component: Main Composing the core Shadow executable

Projects

None yet

Milestone

Fully support process-based simulatio...

Development

Successfully merging this pull request may close these issues.

Make preload+seccomp the default interposition mode

2 participants

@sporksmith @stevenengler