Skip to content

Warn if memory or fd usage is high#1644

Merged
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:warn-low-resources
Sep 16, 2021
Merged

Warn if memory or fd usage is high#1644
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:warn-low-resources

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

@stevenengler stevenengler commented Sep 15, 2021

For #1358.

@stevenengler stevenengler added the Type: Enhancement New functionality or improved design label Sep 15, 2021
@stevenengler stevenengler self-assigned this Sep 15, 2021
@github-actions github-actions bot added the Component: Main Composing the core Shadow executable label Sep 15, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 15, 2021 •
edited
Loading

Codecov Report

Merging #1644 (5879125) into main (9117568) will decrease coverage by 0.01%.
The diff coverage is 41.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1644      +/-   ##
==========================================
- Coverage   54.54%   54.52%   -0.02%     
==========================================
  Files         140      140              
  Lines       18525    18561      +36     
  Branches     4462     4471       +9     
==========================================
+ Hits        10104    10121      +17     
- Misses       5764     5773       +9     
- Partials     2657     2667      +10
Flag Coverage Δ
tests 54.52% <41.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/core/manager.c 66.10% <41.66%> (-2.34%) ⬇️
src/main/host/status_listener.c 68.00% <0.00%> (-2.00%) ⬇️
src/test/futex/test_futex.c 64.21% <0.00%> (-1.06%) ⬇️
src/main/host/descriptor/epoll.c 77.12% <0.00%> (-0.33%) ⬇️
src/main/host/descriptor/file.c 29.29% <0.00%> (-0.19%) ⬇️
src/lib/tsc/tsc_test.c 30.37% <0.00%> (ø)
src/main/host/syscall/socket.c 78.78% <0.00%> (+0.14%) ⬆️
src/main/core/scheduler/scheduler.c 74.86% <0.00%> (+0.52%) ⬆️
src/main/host/syscall/unistd.c 58.38% <0.00%> (+0.57%) ⬆️
src/main/host/syscall/mman.c 62.12% <0.00%> (+0.75%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9117568...5879125. Read the comment docs.

sporksmith
sporksmith approved these changes Sep 16, 2021
View reviewed changes
@stevenengler stevenengler merged commit ff671ff into shadow:main Sep 16, 2021
@stevenengler stevenengler deleted the warn-low-resources branch September 16, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sporksmith sporksmith sporksmith approved these changes

Assignees

@stevenengler stevenengler

Labels

Component: Main Composing the core Shadow executable Type: Enhancement New functionality or improved design

Projects

None yet

Milestone

Code health and maintenance

Development

Successfully merging this pull request may close these issues.

2 participants

@stevenengler @sporksmith