Skip to content

Support FIONBIO for eventfd descriptors#1638

Merged
stevenengler merged 2 commits intoshadow:mainfrom
stevenengler:fionbio-eventfd
Sep 13, 2021
Merged

Support FIONBIO for eventfd descriptors#1638
stevenengler merged 2 commits intoshadow:mainfrom
stevenengler:fionbio-eventfd

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

For #1637.

@stevenengler stevenengler added Type: Enhancement New functionality or improved design Component: Main Composing the core Shadow executable labels Sep 13, 2021
@stevenengler stevenengler self-assigned this Sep 13, 2021
@github-actions github-actions bot added the Component: Testing Unit and integration tests and frameworks label Sep 13, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 13, 2021

Codecov Report

Merging #1638 (29be5f0) into main (3d8e698) will decrease coverage by 0.08%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1638      +/-   ##
==========================================
- Coverage   54.70%   54.62%   -0.09%     
==========================================
  Files         140      140              
  Lines       18468    18519      +51     
  Branches     4436     4455      +19     
==========================================
+ Hits        10103    10116      +13     
- Misses       5714     5748      +34     
- Partials     2651     2655       +4     
Flag Coverage Δ
tests 54.62% <20.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/host/syscall/ioctl.c 38.34% <20.00%> (-11.66%) ⬇️
src/main/host/descriptor/epoll.c 77.12% <0.00%> (-0.66%) ⬇️
src/main/utility/utility.c 13.20% <0.00%> (-0.48%) ⬇️
src/main/host/descriptor/socket.c 65.64% <0.00%> (-0.39%) ⬇️
src/main/host/descriptor/file.c 29.47% <0.00%> (+0.18%) ⬆️
src/main/host/network_interface.c 72.75% <0.00%> (+0.28%) ⬆️
src/main/core/worker.c 75.25% <0.00%> (+0.66%) ⬆️
src/main/host/descriptor/descriptor.c 75.00% <0.00%> (+0.73%) ⬆️
src/test/futex/test_futex.c 65.26% <0.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d8e698...29be5f0. Read the comment docs.

@stevenengler stevenengler merged commit 48306b7 into shadow:main Sep 13, 2021
@stevenengler stevenengler deleted the fionbio-eventfd branch September 13, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Main Composing the core Shadow executable Component: Testing Unit and integration tests and frameworks Type: Enhancement New functionality or improved design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants