Skip to content

Added a simulation status bar#1634

Merged
stevenengler merged 3 commits intoshadow:mainfrom
stevenengler:progress-bar
Sep 13, 2021
Merged

Added a simulation status bar#1634
stevenengler merged 3 commits intoshadow:mainfrom
stevenengler:progress-bar

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

@stevenengler stevenengler commented Sep 9, 2021

Can be enabled using the --progress option.

Screenshot (has changed slightly in revisions):

1631223662_grim

@stevenengler stevenengler added the Type: Enhancement New functionality or improved design label Sep 9, 2021
@stevenengler stevenengler self-assigned this Sep 9, 2021
@github-actions github-actions bot added Component: Documentation In-repository documentation, under docs/ Component: Main Composing the core Shadow executable labels Sep 9, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 9, 2021

Codecov Report

Merging #1634 (87c9b4a) into main (3d8e698) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 87c9b4a differs from pull request most recent head 0fa848a. Consider uploading reports for the commit 0fa848a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1634      +/-   ##
==========================================
- Coverage   54.70%   54.68%   -0.02%     
==========================================
  Files         140      141       +1     
  Lines       18468    18596     +128     
  Branches     4436     4470      +34     
==========================================
+ Hits        10103    10170      +67     
- Misses       5714     5750      +36     
- Partials     2651     2676      +25     
Flag Coverage Δ
tests 54.68% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/core/manager.c 68.43% <0.00%> (-1.68%) ⬇️
src/main/core/main.c 52.94% <0.00%> (-9.56%) ⬇️
src/main/utility/utility.c 13.20% <0.00%> (-0.48%) ⬇️
src/lib/tsc/tsc_test.c 30.37% <0.00%> (ø)
src/test/tcp/test_tcp.c 33.95% <0.00%> (ø)
src/main/host/descriptor/epoll.c 77.77% <0.00%> (ø)
src/main/host/descriptor/socket.c 66.03% <0.00%> (ø)
src/main/utility/disable_aslr.c 57.14% <0.00%> (ø)
src/main/host/syscall/socket.c 78.78% <0.00%> (+0.14%) ⬆️
src/main/core/worker.c 75.25% <0.00%> (+0.66%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48306b7...0fa848a. Read the comment docs.

@stevenengler stevenengler changed the title Added a simulation progress bar Added a simulation status bar Sep 9, 2021
Copy link
Copy Markdown
Contributor

@sporksmith sporksmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm excited for this change!

I don't see a way to make this more flexible without making it a
lot more complicated.
Can be enabled using the '--progress' option.
@stevenengler stevenengler merged commit dc78b33 into shadow:main Sep 13, 2021
@stevenengler stevenengler deleted the progress-bar branch September 13, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Documentation In-repository documentation, under docs/ Component: Main Composing the core Shadow executable Type: Enhancement New functionality or improved design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants