Error if two hosts have the same hostname#1630
Merged
stevenengler merged 2 commits intoshadow:mainfrom Sep 7, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1630 +/- ##
==========================================
+ Coverage 54.44% 54.53% +0.09%
==========================================
Files 141 141
Lines 18610 18616 +6
Branches 4466 4468 +2
==========================================
+ Hits 10132 10153 +21
+ Misses 5798 5789 -9
+ Partials 2680 2674 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sporksmith
approved these changes
Sep 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous behaviour was that one host would be "overwritten" by the other with the same name.