Skip to content

Partially support sys_clock_nanosleep#1607

Merged
stevenengler merged 2 commits intoshadow:mainfrom
stevenengler:clock-nanosleep
Aug 27, 2021
Merged

Partially support sys_clock_nanosleep#1607
stevenengler merged 2 commits intoshadow:mainfrom
stevenengler:clock-nanosleep

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

@stevenengler stevenengler commented Aug 27, 2021

Support sys_clock_nanosleep when there are no flags and when using only the realtime or monotonic clocks.

@stevenengler stevenengler added the Type: Enhancement New functionality or improved design label Aug 27, 2021
@stevenengler stevenengler self-assigned this Aug 27, 2021
@github-actions github-actions bot added Component: Main Composing the core Shadow executable Component: Testing Unit and integration tests and frameworks labels Aug 27, 2021
@stevenengler stevenengler enabled auto-merge August 27, 2021 16:57
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 27, 2021 •
edited
Loading

Codecov Report

Merging #1607 (0675f40) into main (6ccc2a4) will decrease coverage by 0.00%.
The diff coverage is 56.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1607      +/-   ##
==========================================
- Coverage   54.17%   54.16%   -0.01%     
==========================================
  Files         141      141              
  Lines       18574    18594      +20     
  Branches     4455     4458       +3     
==========================================
+ Hits        10063    10072       +9     
- Misses       5854     5866      +12     
+ Partials     2657     2656       -1
Flag Coverage Δ
tests 54.16% <56.52%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/host/syscall/time.c 32.30% <54.54%> (+8.39%) ⬆️
src/main/host/syscall_handler.c 52.94% <100.00%> (-0.23%) ⬇️
src/lib/logger/log_level.c 13.63% <0.00%> (-4.55%) ⬇️
src/lib/tsc/tsc.c 32.39% <0.00%> (-1.41%) ⬇️
src/main/core/scheduler/scheduler.c 73.79% <0.00%> (-1.07%) ⬇️
src/main/host/syscall_condition.c 69.23% <0.00%> (-0.49%) ⬇️
src/main/host/tracker.c 38.64% <0.00%> (-0.34%) ⬇️
src/main/host/descriptor/epoll.c 77.45% <0.00%> (-0.33%) ⬇️
src/lib/tsc/tsc_test.c 30.37% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ccc2a4...0675f40. Read the comment docs.

sporksmith
sporksmith approved these changes Aug 27, 2021
View reviewed changes
@stevenengler
Return ENOSYS for sys_clock_gettime with CPUTIME clocks
83d8d55
@stevenengler
Partially support sys_clock_nanosleep
0675f40 
Support sys_clock_nanosleep when there are no flags and when not
using the CPUTIME clocks.
@stevenengler stevenengler merged commit 1d6c17a into shadow:main Aug 27, 2021
@stevenengler stevenengler deleted the clock-nanosleep branch August 27, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sporksmith sporksmith sporksmith approved these changes

Assignees

@stevenengler stevenengler

Labels

Component: Main Composing the core Shadow executable Component: Testing Unit and integration tests and frameworks Type: Enhancement New functionality or improved design

Projects

None yet

Milestone

Code health and maintenance

Development

Successfully merging this pull request may close these issues.

2 participants

@stevenengler @sporksmith