Simplify syscall condition and timeouts#1583
Merged
sporksmith merged 9 commits intoshadow:mainfrom Aug 20, 2021
Merged
Conversation
Once a signal has been scheduled for a condition, never schedule another signal for that condition, even after the first signal is delivered. We never intentionally reuse a condition in practice, but the previous behavior opened the door to confusing bugs if the condition *was* triggered again in between its handler running and it being canceled.
This makes the triggering syscall condition, when applicable, available to the handler.
We already have a timer in the SysCallCondition, which in practice was always aliased to SysCallHandler.timer. Deduplicate, and encapsulate in the SysCallCondition.
Codecov Report
@@ Coverage Diff @@
## main #1583 +/- ##
==========================================
- Coverage 52.67% 52.48% -0.19%
==========================================
Files 141 141
Lines 21262 21286 +24
Branches 5378 5380 +2
==========================================
- Hits 11200 11173 -27
- Misses 7089 7149 +60
+ Partials 2973 2964 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is primarily to make timeout handling easier to expose in Rust.