Respect shadow's initial CPU affinity#1575
Merged
sporksmith merged 1 commit intoshadow:mainfrom Aug 13, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1575 +/- ##
==========================================
- Coverage 52.73% 52.69% -0.04%
==========================================
Files 141 141
Lines 21243 21260 +17
Branches 5376 5381 +5
==========================================
+ Hits 11202 11203 +1
- Misses 7080 7086 +6
- Partials 2961 2971 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
stevenengler
approved these changes
Aug 13, 2021
Progress on shadow#1565 Fixes shadow#1576
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, with pinning enabled, Shadow would ignore its initial CPU affinity when assigning threads to CPUs. With this change, it checks the initial affinity, and only considers assigning to CPUs in the initial affinity set.
Progress on #1565