Skip to content

Fixed bug where epoll ready list contained non-ready items#1548

Merged
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:epoll-bug
Aug 2, 2021
Merged

Fixed bug where epoll ready list contained non-ready items#1548
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:epoll-bug

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

@stevenengler stevenengler commented Jul 30, 2021 •
edited
Loading

Fixes the issue where shadow gets stuck in #1540. The bug occurs with edge-triggered watch objects.

@stevenengler stevenengler added Type: Bug Error or flaw producing unexpected results Component: Main Composing the core Shadow executable labels Jul 30, 2021
@stevenengler stevenengler self-assigned this Jul 30, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 30, 2021 •
edited
Loading

Codecov Report

Merging #1548 (2c9da44) into main (2d821fa) will decrease coverage by 0.00%.
The diff coverage is 73.33%.

❗ Current head 2c9da44 differs from pull request most recent head 0d84709. Consider uploading reports for the commit 0d84709 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1548      +/-   ##
==========================================
- Coverage   52.59%   52.59%   -0.01%     
==========================================
  Files         141      141              
  Lines       21226    21248      +22     
  Branches     5364     5373       +9     
==========================================
+ Hits        11164    11175      +11     
- Misses       7111     7116       +5     
- Partials     2951     2957       +6
Flag Coverage Δ
tests 52.59% <73.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/host/descriptor/epoll.c 77.37% <73.33%> (-0.72%) ⬇️
src/lib/logger/log_level.c 13.63% <0.00%> (-4.55%) ⬇️
src/main/core/worker.c 74.65% <0.00%> (-0.69%) ⬇️
src/main/host/process.c 69.37% <0.00%> (-0.57%) ⬇️
src/main/host/syscall/unistd.c 49.26% <0.00%> (-0.50%) ⬇️
src/main/host/network_interface.c 72.46% <0.00%> (-0.29%) ⬇️
src/lib/logger/rust_bindings/src/lib.rs 36.12% <0.00%> (-0.05%) ⬇️
src/lib/tsc/tsc_test.c 30.37% <0.00%> (ø)
src/main/host/descriptor/file.c 29.47% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d821fa...0d84709. Read the comment docs.

@stevenengler stevenengler requested a review from robgjansen July 30, 2021 17:24
@stevenengler stevenengler enabled auto-merge July 30, 2021 17:47
@stevenengler stevenengler mentioned this pull request Jul 30, 2021
Closed
4 tasks
robgjansen
robgjansen requested changes Aug 2, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@robgjansen robgjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could be more efficient (see comment); let me know if you want to discuss.

@stevenengler stevenengler requested a review from robgjansen August 2, 2021 20:44
@stevenengler stevenengler merged commit 5021602 into shadow:main Aug 2, 2021
@stevenengler stevenengler deleted the epoll-bug branch August 3, 2021 02:09
@stevenengler stevenengler mentioned this pull request Aug 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robgjansen robgjansen robgjansen approved these changes

Assignees

@stevenengler stevenengler

Labels

Component: Main Composing the core Shadow executable Type: Bug Error or flaw producing unexpected results

Projects

None yet

Milestone

Code health and maintenance

Development

Successfully merging this pull request may close these issues.

2 participants

@stevenengler @robgjansen