Skip to content

Support 'epoll_pwait' syscall when given a NULL sigmask#1544

Merged
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:epoll-pwait
Jul 29, 2021
Merged

Support 'epoll_pwait' syscall when given a NULL sigmask#1544
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:epoll-pwait

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

The epoll_pwait syscall with a NULL signal mask is equivalent to calling epoll_wait. Golang uses epoll_pwait rather than epoll_wait in its runtime scheduler.

@stevenengler stevenengler added the Component: Main Composing the core Shadow executable label Jul 28, 2021
@stevenengler stevenengler requested a review from robgjansen July 28, 2021 21:03
@stevenengler stevenengler self-assigned this Jul 28, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 28, 2021

Codecov Report

Merging #1544 (42cba27) into main (1d1b1a5) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1544      +/-   ##
==========================================
+ Coverage   52.57%   52.61%   +0.03%     
==========================================
  Files         141      141              
  Lines       21209    21216       +7     
  Branches     5360     5361       +1     
==========================================
+ Hits        11150    11162      +12     
- Misses       7106     7112       +6     
+ Partials     2953     2942      -11     
Flag Coverage Δ
tests 52.61% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/host/syscall/epoll.c 58.00% <0.00%> (-3.71%) ⬇️
src/main/host/syscall_handler.c 53.94% <0.00%> (-0.23%) ⬇️
src/main/core/worker.c 74.65% <0.00%> (-0.69%) ⬇️
src/main/host/syscall/unistd.c 49.26% <0.00%> (-0.50%) ⬇️
src/lib/tsc/tsc_test.c 30.37% <0.00%> (ø)
src/lib/logger/rust_bindings/src/lib.rs 36.17% <0.00%> (+0.04%) ⬆️
src/main/host/descriptor/file.c 29.47% <0.00%> (+0.18%) ⬆️
src/main/host/process.c 72.21% <0.00%> (+2.26%) ⬆️
src/lib/logger/log_level.c 18.18% <0.00%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fca3be...42cba27. Read the comment docs.

The 'epoll_pwait' syscall with a NULL signal mask is equivalent to
calling 'epoll_wait'. Golang uses 'epoll_pwait' rather than
'epoll_wait' in its runtime scheduler.
@stevenengler stevenengler merged commit 58336db into shadow:main Jul 29, 2021
@stevenengler stevenengler deleted the epoll-pwait branch July 29, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Main Composing the core Shadow executable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants