Skip to content

Graceful exit when program path doesn't exist#1529

Merged
sporksmith merged 1 commit intoshadow:mainfrom
sporksmith:missing-bin
Jul 21, 2021
Merged

Graceful exit when program path doesn't exist#1529
sporksmith merged 1 commit intoshadow:mainfrom
sporksmith:missing-bin

Conversation

@sporksmith
Copy link
Copy Markdown
Contributor

Fixes #1522

@sporksmith sporksmith requested a review from stevenengler July 21, 2021 19:11
@github-actions github-actions bot added the Component: Main Composing the core Shadow executable label Jul 21, 2021
@sporksmith sporksmith enabled auto-merge (squash) July 21, 2021 19:11
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 21, 2021

Codecov Report

Merging #1529 (83eded8) into main (f3945bd) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1529      +/-   ##
==========================================
- Coverage   52.59%   52.59%   -0.01%     
==========================================
  Files         141      141              
  Lines       21170    21171       +1     
  Branches     5348     5348              
==========================================
  Hits        11135    11135              
- Misses       7089     7090       +1     
  Partials     2946     2946              
Flag Coverage Δ
tests 52.59% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/core/controller.c 76.66% <0.00%> (-0.43%) ⬇️
src/main/host/descriptor/descriptor.c 74.26% <0.00%> (-0.74%) ⬇️
src/main/host/syscall/unistd.c 49.26% <0.00%> (-0.50%) ⬇️
src/main/host/network_interface.c 72.46% <0.00%> (-0.29%) ⬇️
src/test/tcp/test_tcp.c 33.95% <0.00%> (ø)
src/main/host/syscall/fileat.c 15.78% <0.00%> (+0.37%) ⬆️
src/test/futex/test_futex.c 65.05% <0.00%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3945bd...83eded8. Read the comment docs.

@sporksmith sporksmith merged commit fb195ed into shadow:main Jul 21, 2021
@sporksmith sporksmith deleted the missing-bin branch July 21, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Main Composing the core Shadow executable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide a clearer error message when process binary isn't found

2 participants