spec-store-bypass: add a warning and documentation#1510
Merged
sporksmith merged 2 commits intoshadow:mainfrom Jul 14, 2021
Merged
spec-store-bypass: add a warning and documentation#1510sporksmith merged 2 commits intoshadow:mainfrom
sporksmith merged 2 commits intoshadow:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1510 +/- ##
==========================================
+ Coverage 52.92% 52.94% +0.02%
==========================================
Files 140 140
Lines 21036 21043 +7
Branches 5321 5323 +2
==========================================
+ Hits 11134 11142 +8
- Misses 6968 6969 +1
+ Partials 2934 2932 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Contributor
Author
|
The Tor test failure looks like unrelated flakiness; digging into it |
stevenengler
approved these changes
Jul 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1489.