Skip to content

spec-store-bypass: add a warning and documentation#1510

Merged
sporksmith merged 2 commits intoshadow:mainfrom
sporksmith:spec-store-bypass
Jul 14, 2021
Merged

spec-store-bypass: add a warning and documentation#1510
sporksmith merged 2 commits intoshadow:mainfrom
sporksmith:spec-store-bypass

Conversation

@sporksmith
Copy link
Copy Markdown
Contributor

Fixes #1489.

@github-actions github-actions bot added Component: Documentation In-repository documentation, under docs/ Component: Main Composing the core Shadow executable labels Jul 13, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 13, 2021

Codecov Report

Merging #1510 (6ea2ac8) into main (e60738d) will increase coverage by 0.02%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1510      +/-   ##
==========================================
+ Coverage   52.92%   52.94%   +0.02%     
==========================================
  Files         140      140              
  Lines       21036    21043       +7     
  Branches     5321     5323       +2     
==========================================
+ Hits        11134    11142       +8     
- Misses       6968     6969       +1     
+ Partials     2934     2932       -2     
Flag Coverage Δ
tests 52.94% <42.85%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/core/main.c 48.06% <42.85%> (-0.30%) ⬇️
src/test/futex/test_futex.c 63.97% <0.00%> (-1.08%) ⬇️
src/main/host/process.c 69.67% <0.00%> (-0.19%) ⬇️
src/main/host/syscall/socket.c 78.30% <0.00%> (-0.15%) ⬇️
src/test/tcp/test_tcp.c 33.95% <0.00%> (ø)
src/main/routing/packet.c 71.30% <0.00%> (ø)
src/main/host/thread_ptrace.c 49.50% <0.00%> (+0.16%) ⬆️
src/main/routing/topology.c 46.98% <0.00%> (+0.26%) ⬆️
src/main/host/network_interface.c 72.75% <0.00%> (+0.28%) ⬆️
src/main/host/tracker.c 38.98% <0.00%> (+0.33%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e60738d...6ea2ac8. Read the comment docs.

@sporksmith sporksmith requested a review from stevenengler July 13, 2021 16:31
@sporksmith
Copy link
Copy Markdown
Contributor Author

The Tor test failure looks like unrelated flakiness; digging into it

@sporksmith sporksmith enabled auto-merge (squash) July 14, 2021 19:50
@sporksmith sporksmith merged commit 62c793f into shadow:main Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Documentation In-repository documentation, under docs/ Component: Main Composing the core Shadow executable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warn user if speculative stores are disabled

2 participants