Skip to content

Fixed bug when using AT_FDCWD#1500

Merged
stevenengler merged 2 commits intoshadow:mainfrom
stevenengler:support-rm
Jul 9, 2021
Merged

Fixed bug when using AT_FDCWD#1500
stevenengler merged 2 commits intoshadow:mainfrom
stevenengler:support-rm

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

Closes #1495.

@stevenengler stevenengler added Component: Testing Unit and integration tests and frameworks Component: Main Composing the core Shadow executable labels Jul 7, 2021
@stevenengler stevenengler self-assigned this Jul 7, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 7, 2021

Codecov Report

Merging #1500 (829b32b) into main (9a98de9) will decrease coverage by 0.27%.
The diff coverage is 9.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1500      +/-   ##
==========================================
- Coverage   53.26%   52.99%   -0.28%     
==========================================
  Files         140      140              
  Lines       20875    21004     +129     
  Branches     5282     5318      +36     
==========================================
+ Hits        11120    11131      +11     
- Misses       6830     6940     +110     
- Partials     2925     2933       +8     
Flag Coverage Δ
tests 52.99% <9.84%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/host/syscall/fileat.c 15.41% <7.14%> (-0.46%) ⬇️
src/main/host/descriptor/file.c 29.29% <7.74%> (-4.64%) ⬇️
src/test/file/test_file.c 49.79% <50.00%> (+<0.01%) ⬆️
src/main/host/descriptor/timer.c 72.12% <0.00%> (-1.22%) ⬇️
src/main/core/worker.c 75.17% <0.00%> (-0.69%) ⬇️
...main/core/scheduler/scheduler_policy_host_single.c 75.00% <0.00%> (-0.68%) ⬇️
src/main/host/network_interface.c 72.46% <0.00%> (-0.58%) ⬇️
src/main/utility/utility.c 18.39% <0.00%> (-0.48%) ⬇️
src/main/host/syscall/socket.c 78.30% <0.00%> (-0.15%) ⬇️
src/main/host/descriptor/epoll.c 78.09% <0.00%> (+0.35%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a98de9...829b32b. Read the comment docs.

@stevenengler stevenengler requested a review from sporksmith July 7, 2021 22:35
@stevenengler stevenengler requested a review from sporksmith July 9, 2021 15:41
@stevenengler stevenengler merged commit 4730119 into shadow:main Jul 9, 2021
@stevenengler stevenengler deleted the support-rm branch July 9, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Main Composing the core Shadow executable Component: Testing Unit and integration tests and frameworks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"File at" syscalls with the AT_FDCWD fd don't work correctly in Shadow

2 participants