Unref partial packet during tcp free#1483
Merged
stevenengler merged 1 commit intoshadow:mainfrom Jun 29, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1483 +/- ##
==========================================
- Coverage 53.69% 53.69% -0.01%
==========================================
Files 137 137
Lines 20647 20651 +4
Branches 5234 5235 +1
==========================================
+ Hits 11087 11089 +2
- Misses 6637 6639 +2
Partials 2923 2923
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1413.
This bug is unrelated to the issue that prevents newer versions of tor from running properly in Shadow.
After running a 1% network for 60 simulated minutes, there were no packets leaked.