seccomp: Disable Speculative Store Bypass mitigation#1471
Merged
sporksmith merged 1 commit intoshadow:mainfrom Jun 23, 2021
Merged
seccomp: Disable Speculative Store Bypass mitigation#1471sporksmith merged 1 commit intoshadow:mainfrom
sporksmith merged 1 commit intoshadow:mainfrom
Conversation
By default, installing a seccomp filter sets the PR_SPEC_FORCE_DISABLE bit (see prctl(2)). This results in a significant performance penalty. Meanwhile Shadow is semi-cooperative with its virtual processes; it doesn't try to protect itself or the system from malicious code. Hence, it isn't worth paying this overhead. Here we use the SECCOMP_FILTER_FLAG_SPEC_ALLOW to override this behavior.
Codecov Report
@@ Coverage Diff @@
## main #1471 +/- ##
==========================================
- Coverage 53.71% 53.70% -0.02%
==========================================
Files 137 137
Lines 20538 20538
Branches 5196 5196
==========================================
- Hits 11033 11030 -3
- Misses 6603 6605 +2
- Partials 2902 2903 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Member
|
Hmm, I wonder why the testing label got added. That seems like a bug in the PR labeler. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, installing a seccomp filter sets the PR_SPEC_FORCE_DISABLE
bit (see prctl(2)). This results in a significant performance penalty.
Meanwhile Shadow is semi-cooperative with its virtual processes; it
doesn't try to protect itself or the system from malicious code. Hence,
it isn't worth paying this overhead.
Here we use the SECCOMP_FILTER_FLAG_SPEC_ALLOW to override this
behavior.