thread_preload: use seccomp to interpose all syscalls#1452
Merged
sporksmith merged 4 commits intoshadow:mainfrom Jun 21, 2021
Merged
thread_preload: use seccomp to interpose all syscalls#1452sporksmith merged 4 commits intoshadow:mainfrom
sporksmith merged 4 commits intoshadow:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1452 +/- ##
==========================================
- Coverage 53.98% 53.72% -0.27%
==========================================
Files 137 137
Lines 20415 20538 +123
Branches 5167 5196 +29
==========================================
+ Hits 11022 11034 +12
- Misses 6495 6601 +106
- Partials 2898 2903 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
0bb5608 to
5505f5e
Compare
stevenengler
requested changes
Jun 21, 2021
stevenengler
approved these changes
Jun 21, 2021
Installs a seccomp filter from the shim, which catches any syscalls that would otherwise be missed. The filter allows syscalls that originate from the shim itself. Other syscalls cause a SIGSYS; in the SIGSYS handler we can process the syscall as appropriate (e.g. emulate it via Shadow).
7395337 to
9e53769
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installs a seccomp filter from the shim in preload-mode, which catches any syscalls that would otherwise be missed. The filter allows syscalls that originate from the shim itself. Other syscalls cause a SIGSYS; in the SIGSYS handler we can process the syscall as appropriate (e.g. emulate it via Shadow). Can disable with
--use-seccomp=falseSemi-fixes #1168. This is a somewhat different approach than described there, but if this approach works out, then we probably don't need the one described in #1168.
Recompiled libc no longer needed to interpose remaining syscalls, fixing #892