Port LogicalProcessors to Rust#1434
Merged
sporksmith merged 15 commits intoshadow:mainfrom Jun 15, 2021
Merged
Conversation
a8487e1 to
8cccc38
Compare
Codecov Report
@@ Coverage Diff @@
## main #1434 +/- ##
==========================================
- Coverage 56.43% 54.02% -2.41%
==========================================
Files 141 137 -4
Lines 20165 20395 +230
Branches 5018 5155 +137
==========================================
- Hits 11380 11019 -361
- Misses 5880 6470 +590
- Partials 2905 2906 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
stevenengler
requested changes
Jun 15, 2021
Contributor
stevenengler
left a comment
There was a problem hiding this comment.
Marked as "request changes" mostly for the performance effects of not making the idle timer a compile-time option, and for the basic_timer code not having a license (I'm not sure how important this is in reality).
stevenengler
approved these changes
Jun 15, 2021
1738161 to
2efeb91
Compare
When auto-configuring the number of worker threads to create, we were counting the number of host *entries* instead of the number of hosts. Each entry has a *quantity* field that we must account for.
2efeb91 to
8903c11
Compare
For some reason the github CI seems to keep using a stale version of the "shadow-fork" branch. Locking to a specific commit will ensure there's no confusion about what version it's using, and prevent "silent" updates via the vsnprintf repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was mostly an experiment of using c2rust to translate a single C file.
Also fixes:
--use-perf-timers.