Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1417 +/- ##
=======================================
Coverage 54.11% 54.11%
=======================================
Files 138 138
Lines 20462 20462
Branches 5172 5172
=======================================
Hits 11072 11072
Misses 6470 6470
Partials 2920 2920
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
stevenengler
approved these changes
Jun 11, 2021
For the most part, the user doesn't need to know that processes in a simulation are implemented using native processes on the host machine. In those places, the more abstract term "virtual process" makes more sense. When referring specifically to the real process running on the host OS, "managed process" is probably still the best term. This comes up e.g. in developer/debugging docs, and in some experimental options.
a382020 to
9cb3837
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Plugin" no longer makes sense for Shadow 2.0. Initially we talked about using "managed process" anywhere we would otherwise say "plugin". On further discussion, "virtual" process is a little better when talking about the more abstract concept of a process in the simulation vs the native process used to help implement it.