Skip to content

Change install prefix to '~/.local'#1404

Merged
stevenengler merged 2 commits intoshadow:devfrom
stevenengler:install-prefix
Jun 8, 2021
Merged

Change install prefix to '~/.local'#1404
stevenengler merged 2 commits intoshadow:devfrom
stevenengler:install-prefix

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

No description provided.

@stevenengler stevenengler added Type: Maintenance Refactoring, cleanup, documenation, or process improvements Component: Build Build/install tools and dependencies labels Jun 7, 2021
@stevenengler stevenengler self-assigned this Jun 7, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 7, 2021

Codecov Report

Merging #1404 (c6b4b0f) into dev (132ac88) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1404   +/-   ##
=======================================
  Coverage   54.11%   54.12%           
=======================================
  Files         138      138           
  Lines       20438    20438           
  Branches     5164     5164           
=======================================
+ Hits        11061    11062    +1     
+ Misses       6463     6462    -1     
  Partials     2914     2914           
Flag Coverage Δ
tests 54.12% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/host/thread_ptrace.c 49.50% <0.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 623e101...c6b4b0f. Read the comment docs.

@stevenengler stevenengler marked this pull request as ready for review June 7, 2021 14:40
@stevenengler stevenengler requested a review from robgjansen June 7, 2021 15:10
@robgjansen
Copy link
Copy Markdown
Member

Do we want to changesrc/test/tor/minimal/tor-minimal.yaml so that each relay uses:

  • --defaults-torrc to load common configs
  • -f to load a local, node-specific config file (rather than a share conf in ../../config/blah.torrc)?

@stevenengler
Copy link
Copy Markdown
Contributor Author

stevenengler commented Jun 8, 2021

Do we want to changesrc/test/tor/minimal/tor-minimal.yaml so that each relay uses:

  • --defaults-torrc to load common configs
  • -f to load a local, node-specific config file (rather than a share conf in ../../config/blah.torrc)?

We talked about this in a meeting and decided to do this, first in this Shadow test, and later in tornettools. I'll leave this for a separate PR.

@stevenengler stevenengler enabled auto-merge June 8, 2021 18:20
@stevenengler stevenengler merged commit 1b244da into shadow:dev Jun 8, 2021
@stevenengler stevenengler deleted the install-prefix branch June 8, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Build Build/install tools and dependencies Type: Maintenance Refactoring, cleanup, documenation, or process improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants