Skip to content

Remove getActiveThread, getActiveProcess, getActiveWorker#1396

Merged
sporksmith merged 2 commits intoshadow:devfrom
sporksmith:remove-get-active
Jun 2, 2021
Merged

Remove getActiveThread, getActiveProcess, getActiveWorker#1396
sporksmith merged 2 commits intoshadow:devfrom
sporksmith:remove-get-active

Conversation

@sporksmith
Copy link
Copy Markdown
Contributor

We no longer store pointers to the "current" objects in the global
Worker, only some information about those objects.

We no longer store pointers to the "current" objects in the global
Worker, only some information *about* those objects.
@sporksmith sporksmith requested a review from stevenengler June 2, 2021 19:02
@sporksmith sporksmith self-assigned this Jun 2, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 2, 2021

Codecov Report

Merging #1396 (240a3bd) into dev (79d4308) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1396      +/-   ##
==========================================
- Coverage   54.12%   54.11%   -0.01%     
==========================================
  Files         138      138              
  Lines       20500    20500              
  Branches     5176     5176              
==========================================
- Hits        11095    11094       -1     
- Misses       6482     6483       +1     
  Partials     2923     2923              
Flag Coverage Δ
tests 54.11% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/host/thread_ptrace.c 49.33% <0.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79d4308...240a3bd. Read the comment docs.

@sporksmith sporksmith enabled auto-merge June 2, 2021 20:02
@sporksmith sporksmith merged commit 8d96c04 into shadow:dev Jun 2, 2021
@sporksmith sporksmith deleted the remove-get-active branch June 2, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants