Remove C usage of getActiveHost, getActiveProcess, getActiveThread#1393
Merged
sporksmith merged 1 commit intoshadow:devfrom Jun 2, 2021
Merged
Remove C usage of getActiveHost, getActiveProcess, getActiveThread#1393sporksmith merged 1 commit intoshadow:devfrom
sporksmith merged 1 commit intoshadow:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1393 +/- ##
==========================================
+ Coverage 54.33% 54.35% +0.01%
==========================================
Files 136 138 +2
Lines 20465 20521 +56
Branches 5169 5176 +7
==========================================
+ Hits 11120 11154 +34
- Misses 6417 6435 +18
- Partials 2928 2932 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
stevenengler
approved these changes
Jun 2, 2021
This is conceptually a follow-up to shadow#1386, but doesn't actually depend on it. Once both this and shadow#1386 are in, we can remove getActiveHost, getActiveProcess, and getActiveThread entirely. This is helpful for porting to Rust since we don't have or want those to be globals there. In C code it suffices to pass around the "deepest" current context object, since they all have "up" pointers. e.g. given a Thread we can get the corresponding Process and Host. We might eventually want to replace these parameters with their Context counterparts in shadow#1386, but this seems like a useful intermediate step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is conceptually a follow-up to #1386, but doesn't actually depend
on it. Once both this and #1386 are in, we can remove getActiveHost,
getActiveProcess, and getActiveThread entirely. This is helpful for
porting to Rust since we don't have or want those to be globals there.
In C code it suffices to pass around the "deepest" current context
object, since they all have "up" pointers. e.g. given a Thread we can
get the corresponding Process and Host. We might eventually want to
replace these parameters with their Context counterparts in #1386, but
this seems like a useful intermediate step.