Skip to content

Renamed topology 'ip' to 'ip_address', and removed the 'asn' and 'packet_loss' node attributes#1356

Merged
stevenengler merged 3 commits intoshadow:devfrom
stevenengler:update-topology-options
May 13, 2021
Merged

Renamed topology 'ip' to 'ip_address', and removed the 'asn' and 'packet_loss' node attributes#1356
stevenengler merged 3 commits intoshadow:devfrom
stevenengler:update-topology-options

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

@stevenengler stevenengler commented May 13, 2021

No description provided.

@stevenengler stevenengler added Type: Maintenance Refactoring, cleanup, documenation, or process improvements Component: Main Composing the core Shadow executable labels May 13, 2021
@stevenengler stevenengler self-assigned this May 13, 2021
@stevenengler stevenengler requested a review from robgjansen May 13, 2021 00:48
@codecov
Copy link
Copy Markdown

codecov bot commented May 13, 2021 •
edited
Loading

Codecov Report

Merging #1356 (c848998) into dev (0a26cae) will increase coverage by 0.00%.
The diff coverage is 92.85%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1356   +/-   ##
=======================================
  Coverage   56.42%   56.42%           
=======================================
  Files         141      141           
  Lines       20127    20084   -43     
  Branches     4998     4977   -21     
=======================================
- Hits        11356    11333   -23     
+ Misses       5882     5869   -13     
+ Partials     2889     2882    -7
Flag Coverage Δ
tests 56.42% <92.85%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/routing/topology.c 45.96% <92.30%> (-0.11%) ⬇️
src/main/core/controller.c 78.77% <100.00%> (ø)
src/main/host/thread_ptrace.c 51.16% <0.00%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a26cae...c848998. Read the comment docs.

@stevenengler stevenengler removed the request for review from robgjansen May 13, 2021 00:59
@stevenengler stevenengler changed the title Renamed topology 'ip' to 'ip_address', and removed 'asn' attribute Renamed topology 'ip' to 'ip_address', and removed the 'asn' and 'packet_loss' node attributes May 13, 2021
@stevenengler stevenengler requested a review from robgjansen May 13, 2021 01:32
@stevenengler stevenengler force-pushed the update-topology-options branch from 1cf4460 to c848998 Compare May 13, 2021 14:26
@stevenengler stevenengler enabled auto-merge May 13, 2021 14:28
@stevenengler stevenengler merged commit b277326 into shadow:dev May 13, 2021
@stevenengler stevenengler deleted the update-topology-options branch May 13, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robgjansen robgjansen robgjansen approved these changes

Assignees

@stevenengler stevenengler

Labels

Component: Main Composing the core Shadow executable Type: Maintenance Refactoring, cleanup, documenation, or process improvements

Projects

None yet

Milestone

Updates to and new formats for Shadow...

Development

Successfully merging this pull request may close these issues.

2 participants

@stevenengler @robgjansen