Skip to content

Remove unused '--interface-batch' option#1305

Merged
stevenengler merged 1 commit intoshadow:devfrom
stevenengler:remove-interface-batch-time
Apr 26, 2021
Merged

Remove unused '--interface-batch' option#1305
stevenengler merged 1 commit intoshadow:devfrom
stevenengler:remove-interface-batch-time

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

This option isn't used anywhere.

@stevenengler stevenengler added Type: Maintenance Refactoring, cleanup, documenation, or process improvements Component: Main Composing the core Shadow executable labels Apr 26, 2021
@stevenengler stevenengler requested a review from robgjansen April 26, 2021 18:35
@stevenengler stevenengler self-assigned this Apr 26, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 26, 2021

Codecov Report

Merging #1305 (c363a05) into dev (913955b) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1305      +/-   ##
==========================================
+ Coverage   55.25%   55.28%   +0.03%     
==========================================
  Files         142      142              
  Lines       20721    20713       -8     
  Branches     5060     5058       -2     
==========================================
+ Hits        11449    11451       +2     
+ Misses       6157     6149       -8     
+ Partials     3115     3113       -2     
Flag Coverage Δ
tests 55.28% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/core/support/options.c 63.08% <ø> (+0.92%) ⬆️
src/main/host/thread_ptrace.c 51.92% <0.00%> (-0.28%) ⬇️
src/main/routing/topology.c 42.34% <0.00%> (+0.24%) ⬆️
src/main/core/worker.c 78.20% <0.00%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 913955b...c363a05. Read the comment docs.

Copy link
Copy Markdown
Member

@robgjansen robgjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stevenengler stevenengler merged commit 7f49974 into shadow:dev Apr 26, 2021
@stevenengler stevenengler deleted the remove-interface-batch-time branch April 26, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Main Composing the core Shadow executable Type: Maintenance Refactoring, cleanup, documenation, or process improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants