Conversation
f9e093c to
2ea0c14
Compare
Codecov Report
@@ Coverage Diff @@
## dev #1304 +/- ##
==========================================
+ Coverage 55.26% 55.29% +0.02%
==========================================
Files 142 142
Lines 20713 20688 -25
Branches 5058 5044 -14
==========================================
- Hits 11448 11440 -8
+ Misses 6151 6144 -7
+ Partials 3114 3104 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
src/main/core/controller.c
Outdated
| gchar* preloadPath = _controller_scanRPathForPreloadShim(); | ||
| if (preloadPath != NULL) { | ||
| message("found %s at %s", PRELOAD_SHIM_LIB_STR, preloadPath); | ||
| } else { | ||
| critical("could not find %s in rpath", PRELOAD_SHIM_LIB_STR); | ||
| return 1; | ||
| } |
There was a problem hiding this comment.
Unless there is some advantage to doing this in the controller that I'm missing, I think the right place to do it is in the manager. Eventually, when we enhance shadow to utilize multiple machines, we'll have one manager per machine but only one single controller per simulation. Each machine (i.e., manager) will have to scan the rpath separately.
I think we can just move all of the code over to manager, and initiate the rpath scan in manager_new?
There was a problem hiding this comment.
Moved this over to the manager.
d26af59 to
a6db27e
Compare
Always get the preload path from the rpath.
a6db27e to
a739efb
Compare
Always get the preload path from the rpath. Closes #1215.