Added a Rust wrapper for parsing cli args using GLib#1286
Merged
stevenengler merged 1 commit intoshadow:devfrom Apr 13, 2021
Merged
Added a Rust wrapper for parsing cli args using GLib#1286stevenengler merged 1 commit intoshadow:devfrom
stevenengler merged 1 commit intoshadow:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1286 +/- ##
==========================================
+ Coverage 55.54% 55.57% +0.02%
==========================================
Files 141 141
Lines 20624 20637 +13
Branches 5066 5070 +4
==========================================
+ Hits 11456 11468 +12
Misses 6044 6044
- Partials 3124 3125 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
729da7e to
e6b3203
Compare
robgjansen
approved these changes
Apr 13, 2021
| pub fn process_parseArgStr( | ||
| commandLine: *const ::std::os::raw::c_char, | ||
| argc: *mut ::std::os::raw::c_int, | ||
| argv: *mut *mut *mut ::std::os::raw::c_char, |
Member
There was a problem hiding this comment.
Huh didn't know *mut *mut *mut would be a thing.
|
|
||
| bool rv = !!g_shell_parse_argv(commandLine, argc, argv, &gError); | ||
| if (!rv && gError != NULL && gError->message != NULL) { | ||
| *error = strdup(gError->message); |
Member
There was a problem hiding this comment.
Are we guaranteed that error is non-null here?
Contributor
Author
There was a problem hiding this comment.
Good catch, I added a check for that.
| InterposeMethod process_getInterposeMethod(Process* proc); | ||
|
|
||
| // A wrapper around GLib's `g_shell_parse_argv()` that doesn't use GLib types. | ||
| bool process_parseArgStr(const char* commandLine, int* argc, char*** argv, char** error); |
Member
There was a problem hiding this comment.
Add a comment on the expectations on the caller for freeing the returned pointers.
e6b3203 to
ac2e39c
Compare
ac2e39c to
667a2e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will call this from Rust when parsing our configuration YAML.