Removed the TCP congestion control option#1270
Merged
stevenengler merged 1 commit intoshadow:devfrom Apr 7, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1270 +/- ##
==========================================
+ Coverage 55.74% 55.76% +0.01%
==========================================
Files 141 141
Lines 20479 20462 -17
Branches 5032 5028 -4
==========================================
- Hits 11416 11410 -6
+ Misses 5949 5943 -6
+ Partials 3114 3109 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
robgjansen
approved these changes
Apr 6, 2021
src/main/host/descriptor/tcp.c
Outdated
| } | ||
| /* in the future we'd like to support more congestion control types | ||
| * and allow it to be set as a host option */ | ||
| TCPCongestionType congestionType = TCP_CC_RENO; |
Member
There was a problem hiding this comment.
I think congestionType is an unused variable, unless I missed it?
82ee317 to
8129ea1
Compare
8129ea1 to
6f9cb39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is only a single congestion control method implemented in the dev branch (reno), so we should remove this option until we support others. Part of #1220.