Remove command-line options and configuration fields#1263
Remove command-line options and configuration fields#1263stevenengler merged 6 commits intoshadow:devfrom
Conversation
6f28196 to
5bfccd4
Compare
Codecov Report
@@ Coverage Diff @@
## dev #1263 +/- ##
==========================================
+ Coverage 55.67% 55.74% +0.06%
==========================================
Files 142 141 -1
Lines 20562 20479 -83
Branches 5053 5032 -21
==========================================
- Hits 11448 11416 -32
+ Misses 5988 5949 -39
+ Partials 3126 3114 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
robgjansen
left a comment
There was a problem hiding this comment.
Always happy to see a bunch of old code removed :)
| params->cpuThreshold = defaultCPUThreshold > 0 ? defaultCPUThreshold : 0; | ||
| gint defaultCPUPrecision = options_getCPUPrecision(controller->options); | ||
| params->cpuPrecision = defaultCPUPrecision > 0 ? defaultCPUPrecision : 0; | ||
| params->cpuThreshold = 0; |
There was a problem hiding this comment.
Should this be 0 or -1? It looks like -1 was the default before to disable cpu delays?
There was a problem hiding this comment.
The params->cpuThreshold = defaultCPUThreshold > 0 ? defaultCPUThreshold : 0 line sets a lower limit of 0, so the -1 would end up as 0 here.
| { "socket-send-buffer", 0, 0, G_OPTION_ARG_INT, &(options->initialSocketSendBufferSize), socksend->str, "N" }, | ||
| { "tcp-congestion-control", 0, 0, G_OPTION_ARG_STRING, &(options->tcpCongestionControl), "Congestion control algorithm to use for TCP ('aimd', 'reno', 'cubic') ['reno']", "TCPCC" }, | ||
| { "tcp-ssthresh", 0, 0, G_OPTION_ARG_INT, &(options->tcpSlowStartThreshold), "Set TCP ssthresh value instead of discovering it via packet loss or hystart [0]", "N" }, | ||
| { "tcp-windows", 0, 0, G_OPTION_ARG_INT, &(options->initialTCPWindow), "Initialize the TCP send, receive, and congestion windows to N packets [10]", "N" }, |
There was a problem hiding this comment.
The getting started tutorial doc has an example that tweaks the --tcp-windows option. We should update that example experiment so it no longer references a non-existent option.
There was a problem hiding this comment.
I updated this example to use different queuing disciplines instead. Let me know if you think there's a better option to use.
| return options->shouldExitAfterShmCleanup; | ||
| } | ||
|
|
||
| const gchar* options_getPreloadString(Options* options) { |
There was a problem hiding this comment.
Huh, this wasn't called anywhere?
There was a problem hiding this comment.
Nope, it looks like all uses were removed in the initial e41c4a9.
52eea99 to
c3716e9
Compare
Removes the following:
Command-line options:
--preload--valgrind--test--tgen--cpu-precision--cpu-threshold--tcp-ssthresh--tcp-windowsConfiguration fields:
cpufrequencyPart of #1220.