Do not use subroutine execution timers by default#1246
Merged
robgjansen merged 1 commit intoshadow:mainfrom Apr 1, 2021
robgjansen:disable-perf-timers-backport
Merged
Do not use subroutine execution timers by default#1246robgjansen merged 1 commit intoshadow:mainfrom robgjansen:disable-perf-timers-backport
robgjansen merged 1 commit intoshadow:mainfrom
robgjansen:disable-perf-timers-backport
Conversation
Shadow includes internal performance timers to help us track execution time of various subroutines. The timer-related functions have shown up on performance profiles as causing significant overhead. These timers are now disabled by default. We add a new --use-perf-timers option to the setup script, and a new USE_PERF_TIMERS option to cmake that allows us to toggle the performance timers back on if desired. Closes #1141 (cherry-picked from commit e9004c2)
sporksmith
approved these changes
Apr 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shadow includes internal performance timers to help us track execution
time of various subroutines. The timer-related functions have shown
up on performance profiles as causing significant overhead. These timers
are now disabled by default.
We add a new --use-perf-timers option to the setup script, and a new
USE_PERF_TIMERS option to cmake that allows us to toggle the performance
timers back on if desired.
Closes #1141
(cherry-picked from commit e9004c2)