Small ioctl and sendto bug fixes, and implement FIONBIO for Nginx#1179
Merged
stevenengler merged 2 commits intoshadow:devfrom Mar 13, 2021
Merged
Small ioctl and sendto bug fixes, and implement FIONBIO for Nginx#1179stevenengler merged 2 commits intoshadow:devfrom
stevenengler merged 2 commits intoshadow:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1179 +/- ##
==========================================
- Coverage 56.93% 56.85% -0.09%
==========================================
Files 140 140
Lines 20181 20195 +14
Branches 4889 4891 +2
==========================================
- Hits 11491 11481 -10
- Misses 5663 5687 +24
Partials 3027 3027
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Contributor
|
Woah, cool! |
robgjansen
approved these changes
Mar 13, 2021
Member
robgjansen
left a comment
There was a problem hiding this comment.
Looks great! I'm excited about Nginx support 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two socket bugs and implements
FIONBIOforioctl()to set a socket as non-blocking, which is required for Nginx.Closes #344.
Nginx can be used with the following (still missing some syscalls and socket options, but it works):
nginx.conf:
shadow-nginx.yaml: