Skip to content

Pinning main#1079

Merged
rwails merged 9 commits intoshadow:masterfrom
rwails:pinning-main
Feb 2, 2021
Merged

Pinning main#1079
rwails merged 9 commits intoshadow:masterfrom
rwails:pinning-main

Conversation

@rwails
Copy link
Copy Markdown
Collaborator

@rwails rwails commented Jan 29, 2021

Adds a CPU-pinning option to Shadow's main branch. The feature is optionally enabled with a CLI switch.

@rwails rwails requested a review from robgjansen January 29, 2021 00:06
@rwails
Copy link
Copy Markdown
Collaborator Author

rwails commented Jan 29, 2021

This is failing CI on errors outside of any modules changed. Is that OK?

@robgjansen
Copy link
Copy Markdown
Member

robgjansen commented Jan 29, 2021

Ugg. When did the deprecated g_memmove become an error? I guess I should fix that first, merge in here, and re-run the CI tests.

@stevenengler
Copy link
Copy Markdown
Contributor

stevenengler commented Jan 29, 2021

Ugg. When did the deprecated g_memmove become an error? I guess I should fix that first, merge in here, and re-run the CI tests.

This might be caused by GiHub changing the ubuntu-latest test runner from Ubuntu 18.04 to 20.04. You can probably just set the runner to ubuntu-18.04 and leave the deprecation fix for a future PR.

shadow/.github/workflows/build_shadow.yml

Lines 15 to 17 in 5e7b83c

jobs:
testing:
runs-on: ubuntu-latest

robgjansen
robgjansen approved these changes Jan 29, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@robgjansen robgjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great, thanks!

I just had two questions that I'm unsure about, which means comments in the code for those items would be helpful (though not required) even if you don't end up changing the code.

@robgjansen robgjansen added Component: Main Composing the core Shadow executable Type: Enhancement New functionality or improved design labels Jan 29, 2021
@robgjansen robgjansen mentioned this pull request Jan 29, 2021
Closed
16 tasks
@rwails rwails merged commit d2fc305 into shadow:master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robgjansen robgjansen robgjansen approved these changes

Assignees

@rwails rwails

Labels

Component: Main Composing the core Shadow executable Type: Enhancement New functionality or improved design

Projects

None yet

Milestone

Fully support process-based simulatio...

Development

Successfully merging this pull request may close these issues.

3 participants

@rwails @robgjansen @stevenengler