Add support for socketpair syscall#1058
Merged
robgjansen merged 3 commits intoshadow:devfrom Dec 17, 2020
robgjansen:syscall-socketpair
Merged
Add support for socketpair syscall#1058robgjansen merged 3 commits intoshadow:devfrom robgjansen:syscall-socketpair
robgjansen merged 3 commits intoshadow:devfrom
robgjansen:syscall-socketpair
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1058 +/- ##
==========================================
+ Coverage 54.82% 55.07% +0.25%
==========================================
Files 127 127
Lines 19177 19231 +54
Branches 4585 4592 +7
==========================================
+ Hits 10513 10592 +79
+ Misses 5898 5871 -27
- Partials 2766 2768 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sporksmith
approved these changes
Dec 17, 2020
| return (SysCallReturn){.state = SYSCALL_DONE, .retval.as_i64 = -EPROTONOSUPPORT}; | ||
| } | ||
|
|
||
| /* TODO: should we actually be running TCP/UDP internally (i.e., using already connected TCP/UDP |
Contributor
There was a problem hiding this comment.
FWIW I don't know of a reason why we'd want that
18 tasks
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passes all existing socketpair tests.
refs #849