-
Notifications
You must be signed in to change notification settings - Fork 268
Remove --profile option from setup script #2405
Copy link
Copy link
Closed
Labels
Type: MaintenanceRefactoring, cleanup, documenation, or process improvementsRefactoring, cleanup, documenation, or process improvements
Description
The setup script has the --profile option to compile with gprof metadata.
We haven't made this work for Rust code, and some cursory searching didn't turn up anyone who has successfully done so. Internally we have been using perf instead, which doesn't require any instrumentation, and works with Rust code.
In WIP #2404 where I'm moving the compilation of most C code into Rust scripts, I'm tentatively not porting the ability to compile the C code with this option. While porting it would be feasible, it's currently of questionable and decreasing value. I'm tentatively marking the setup option deprecated instead, and turning it into a no-op.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Type: MaintenanceRefactoring, cleanup, documenation, or process improvementsRefactoring, cleanup, documenation, or process improvements