fixup! Fix order of operations in codel control law

robgjansen · robgjansen · commit df2288b2ce86 · 2022-10-19T15:08:19.000-04:00
diff --git a/src/main/routing/router_queue_codel.c b/src/main/routing/router_queue_codel.c
@@ -199,8 +199,7 @@ static Packet* _routerqueuecodel_dequeueHelper(QueueManagerCoDel* queueManager,
 static CSimulationTime _routerqueuecodel_controlLaw(guint count, CSimulationTime ts) {
     // control_law: t + (INTERVAL / sqrt(count));
     double result = ((double)CODEL_PARAM_INTERVAL_SIMTIME) / sqrt((double)count);
-    double rounded = round(result);
-    return ts + ((CSimulationTime)rounded);
+    return ts + ((CSimulationTime)result);
 }
 
 static Packet* _routerqueuecodel_dequeue(QueueManagerCoDel* queueManager) {

Original file line number	Diff line number	Diff line change
`@@ -199,8 +199,7 @@ static Packet* _routerqueuecodel_dequeueHelper(QueueManagerCoDel* queueManager,`
`199`	`199`	`static CSimulationTime _routerqueuecodel_controlLaw(guint count, CSimulationTime ts) {`
`200`	`200`	`// control_law: t + (INTERVAL / sqrt(count));`
`201`	`201`	`double result = ((double)CODEL_PARAM_INTERVAL_SIMTIME) / sqrt((double)count);`
`202`		`- double rounded = round(result);`
`203`		`- return ts + ((CSimulationTime)rounded);`
	`202`	`+ return ts + ((CSimulationTime)result);`
`204`	`203`	`}`
`205`	`204`
`206`	`205`	`static Packet* _routerqueuecodel_dequeue(QueueManagerCoDel* queueManager) {`