WKWebView + Xcode 11.2.1 Updates#117
Merged
sgr-ksmt merged 1 commit intosgr-ksmt:masterfrom Nov 12, 2019
Merged
Conversation
Contributor
rlester
commented
Nov 11, 2019
- Replaced UIWebView with WKWebview.
- Updated demo project to support swift 5.1 (Xcode 11.2.1).
- Organized demo projects storyboards into one file.
- Cleaned up linting / formating issues.
- Fixed navigation issues with demo project.
- Updated demo project to support swift 5.1 (Xcode 11.2.1). - Organized demo projects storyboards into one file. - Cleaned up linting / formating issues. - Fixed navigation issues with demo project.
houndci-bot
reviewed
Nov 11, 2019
| public class func generated(by views: [UIView], dpi: DPIType = .default, password: PDFPassword = "") throws -> Data { | ||
|
|
||
| public class func generated(by views: [UIView], dpi: DPIType = .default, password: PDFPassword = "") throws -> Data { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 121 characters (line_length)
|
|
||
| override func viewDidLoad() { | ||
| super.viewDidLoad() | ||
| let req = NSMutableURLRequest(url: URL(string: "http://www.yahoo.co.jp")!, cachePolicy: .reloadIgnoringCacheData, timeoutInterval: 60) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 142 characters (line_length)
| } | ||
|
|
||
| override func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell { | ||
| let cell = tableView.dequeueReusableCell(withIdentifier: "Cell", for: indexPath) as! SampleTableViewCell |
There was a problem hiding this comment.
Force Cast Violation: Force casts should be avoided. (force_cast)
| var window: UIWindow? | ||
|
|
||
| func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?) -> Bool { | ||
| func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 145 characters (line_length)
sgr-ksmt
approved these changes
Nov 12, 2019
Owner
sgr-ksmt
left a comment
There was a problem hiding this comment.
I really appreciate your contribution.
I'll publish a new version of PDFGenerator after fixing code a bit and merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.