[draft] rdk#9539
Closed
keyboardAnt wants to merge 16 commits intosgl-project:mainfrom
Closed
Conversation
…aps/indices_to_keep_by_target_var.pt`)
Author
This was referenced Sep 1, 2025
Collaborator
|
Closed due to inactivity. Please reopen with a clear roadmap if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Implementing RDK from "Out-of-Vocabulary Sampling Boosts Speculative Decoding" (https://arxiv.org/abs/2506.03206). This PR replaces #8393.
Modifications
Accuracy Tests
Benchmarking and Profiling
Comparing the acceptance:
python3 -m sglang.bench_offline_throughput --model-path meta-llama/Meta-Llama-3.1-8B-Instruct --num-prompts 10 --speculative-algorithm EAGLE --speculative-draft-model-path lmsys/sglang-EAGLE-LLaMA3-Instruct-8B --speculative-num-steps 5 --speculative-eagle-topk 8 --speculative-num-draft-tokens 64 --mem-fraction 0.7 --cuda-graph-max-bs 2 --dtype float16 --disable-cuda-graphpython3 -m sglang.bench_offline_throughput --model-path meta-llama/Meta-Llama-3.1-8B-Instruct --num-prompts 10 --speculative-algorithm EAGLE --speculative-draft-model-path lmsys/sglang-EAGLE-LLaMA3-Instruct-8B --speculative-num-steps 5 --speculative-eagle-topk 8 --speculative-num-draft-tokens 64 --mem-fraction 0.7 --cuda-graph-max-bs 2 --dtype float16 --speculative-token-map python/sglang/srt/speculative/token_maps/indices_to_keep_by_tokenizer_freq.pt --disable-cuda-graphpython3 -m sglang.bench_offline_throughput --model-path meta-llama/Meta-Llama-3.1-8B-Instruct --num-prompts 10 --speculative-algorithm EAGLE --speculative-draft-model-path lmsys/sglang-EAGLE-LLaMA3-Instruct-8B --speculative-num-steps 5 --speculative-eagle-topk 8 --speculative-num-draft-tokens 64 --mem-fraction 0.7 --cuda-graph-max-bs 2 --dtype float16 --speculative-token-map python/sglang/srt/speculative/token_maps/indices_to_keep_by_target_var.pt --disable-cuda-graphpython3 -m sglang.bench_offline_throughput --model-path meta-llama/Meta-Llama-3.1-8B-Instruct --num-prompts 10 --speculative-algorithm EAGLE --speculative-draft-model-path lmsys/sglang-EAGLE-LLaMA3-Instruct-8B --speculative-num-steps 5 --speculative-eagle-topk 8 --speculative-num-draft-tokens 64 --mem-fraction 0.7 --cuda-graph-max-bs 2 --dtype float16 --speculative-token-map python/sglang/srt/speculative/token_maps/indices_to_keep_by_tokenizer_freq.pt --speculative-weaker-drafter-probs python/sglang/srt/speculative/token_maps/target-probs-meta-llama-Llama-3.1-8B-Instruct-wikitext-wikitext-103-raw-v1-train.pt --disable-cuda-graphpython3 -m sglang.bench_offline_throughput --model-path meta-llama/Meta-Llama-3.1-8B-Instruct --num-prompts 10 --speculative-algorithm EAGLE --speculative-draft-model-path lmsys/sglang-EAGLE-LLaMA3-Instruct-8B --speculative-num-steps 5 --speculative-eagle-topk 8 --speculative-num-draft-tokens 64 --mem-fraction 0.7 --cuda-graph-max-bs 2 --dtype float16 --speculative-token-map python/sglang/srt/speculative/token_maps/indices_to_keep_by_target_var.pt --speculative-weaker-drafter-probs python/sglang/srt/speculative/token_maps/target-probs-meta-llama-Llama-3.1-8B-Instruct-wikitext-wikitext-103-raw-v1-train.pt --disable-cuda-graphCode used: https://github.com/keyboardAnt/sglang/tree/nadav/exact-socp-rdk (commit 9181631d7ff9e68b9570cc4177470efcf849175f)
`python3 -m sglang.check_env`:
Checklist